Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up some diff-related tests #4793

Merged
merged 3 commits into from
Oct 31, 2024
Merged

clean up some diff-related tests #4793

merged 3 commits into from
Oct 31, 2024

Conversation

ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Oct 31, 2024 •
edited
Loading

fixes #3265

  • fixes an issue with how we handle is_default on attributes with an enum defined
  • reactivates and updates some diff-related tests in the test_user_workflow integration tests
  • adds a unit test to make sure that SchemaAttributes and SchemaRelationships under a deleted SchemaNode are also deleted

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Oct 31, 2024
@ajtmccarty ajtmccarty changed the title Ajtm 10302024 diff test cleanup clean up some diff-related tests Oct 31, 2024
@ajtmccarty ajtmccarty marked this pull request as ready for review October 31, 2024 00:30
@ajtmccarty ajtmccarty requested a review from a team October 31, 2024 00:30
Base automatically changed from release-1.0 to stable October 31, 2024 03:11
@dgarros dgarros merged commit 2e89e34 into stable Oct 31, 2024
28 checks passed
@dgarros dgarros deleted the ajtm-10302024-diff-test-cleanup branch October 31, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarros dgarros dgarros approved these changes

Assignees
No one assigned
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajtmccarty @dgarros